This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
Keep latest tags for branches #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Else we break local development
|
The code make sense, but could you give me a small example of the impact of this? :) |
The impact is that you locally can use the There should not be any other impact, unless the cache is invalidated by two branches pushing the latest tag. Let me know if I can explain this better |
madsnedergaard
approved these changes
Sep 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #61
We recently introduced a change to not not tag images on non-main branches with "latest". This avoids cache breaking as all branches will not all push the "latest" image – but it does break local development where the latest tag is used in Docker compose files.
I have a workaround if this indeed breaks the cache, when two branch builds tags the same repository with the
latesttag and thereby breaks the cache.