You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
Looking through different brick BUILD.yaml files, I noticed that in some steps command is used while in some others there is a list of commands. I assumed the two are actually interchangeable and that both can be used across build, test, develop etc, only to end up trying to figure why test -> command config is always passing the tests - turns out the commands list being empty means no command have been run so it always passes.
Looking at the code, it seems that only develop uses a singular command while all the other steps require commands. I have a few suggestions how we could improve the behaviour:
Switch to commands syntax in develop and completely drop the command option
Support both command and commands options across all steps
Keep things as they are but document the examples better to make it clear develop steps are an exception in the sense that only there exactly one command is expected
Looking through different brick
BUILD.yaml
files, I noticed that in some stepscommand
is used while in some others there is a list ofcommands
. I assumed the two are actually interchangeable and that both can be used acrossbuild
,test
,develop
etc, only to end up trying to figure whytest
->command
config is always passing the tests - turns out thecommands
list being empty means no command have been run so it always passes.Looking at the code, it seems that only
develop
uses a singularcommand
while all the other steps requirecommands
. I have a few suggestions how we could improve the behaviour:commands
syntax indevelop
and completely drop thecommand
optioncommand
andcommands
options across all stepsdevelop
steps are an exception in the sense that only there exactly one command is expectedSee https://github.com/tmrowco/tmrow/issues/3236 for more context.
The text was updated successfully, but these errors were encountered: