Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Doesn't always use previous build cache #24

Closed
corradio opened this issue Mar 24, 2020 · 1 comment
Closed

Doesn't always use previous build cache #24

corradio opened this issue Mar 24, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@corradio
Copy link
Member

Steps to reproduce:

  • brick build
  • do a new commit
  • brick build
  • git revert that commit
  • brick build
    Expected:
    The first brick build should have produced a cache entry, and thus the last brick build (after reverting) should re-use that cache and cause a no-op
@skovhus
Copy link
Contributor

skovhus commented Sep 15, 2020

What happens here is that the second brick build overrides the tag. Docker layers are still cached, so it is rather fast right now.

The only way I see this could be improved is by tagging with branch+commit, which will bloat the docker cache.

If we solve output collection and image caching on branches (#57), then I believe Brick should be fast enough.

I'm closing this for now, please reopen if you disagree.

@skovhus skovhus closed this as completed Sep 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants