This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
Brick prune #22
Merged
Brick prune #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, is there a reason for not using the built-in |
|
Good question. The docker prune command unfortunately doesn't allow
filtering by tag (master/latest) as far as I know.
We already use docker prune on the CI but it's not enough as it doesn't
remove branch builds.
…On Tue, Feb 18, 2020 at 9:37 AM Mads Nedergaard ***@***.***> wrote:
Looks good to me, is there a reason for not using the built-in pruning
feature in Docker?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#22>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMUIKCAT5U6LCJ5R7BSNJTRDOM4VANCNFSM4KW7RHSA>
.
--
Olivier Corradi
Founder, CEO
<https://www.linkedin.com/in/oliviercorradi> <https://twitter.com/corradio>
tmrow.com
|
|
It should be possible to do a label !=xx filtering as far as I can tell :) https://docs.docker.com/engine/reference/commandline/image_prune/#filtering |
|
Yes but unfortunately `label` is not the same as `tag`.. :/
We could however label the images with the branch information, and use that
instead, but that would require rebuilding everything.
…On Tue, Feb 18, 2020 at 9:41 AM Mads Nedergaard ***@***.***> wrote:
It should be possible to do a label != filtering as far as I can tell :)
https://docs.docker.com/engine/reference/commandline/image_prune/#filtering
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#22>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMUIKBZ2YRQ6YVMERGI3X3RDONKXANCNFSM4KW7RHSA>
.
--
Olivier Corradi
Founder, CEO
<https://www.linkedin.com/in/oliviercorradi> <https://twitter.com/corradio>
tmrow.com
|
madsnedergaard
approved these changes
Feb 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19
brick prunecommand which removes images that are NOT tagged as master or latest, and that are more than 3 days old. Note that no-op builds update the tag date. This effectively means we delete builds from branches that are > 3 days old.brick -r prunecc @robertahunt FYI