Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify SlaveAddr. #21

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Simplify SlaveAddr. #21

merged 3 commits into from
Feb 13, 2024

Conversation

reitermarkus
Copy link
Contributor

None of the datasheets mention “alternative” in respect to addresses, so I am not sure why they were named like this.

@reitermarkus reitermarkus force-pushed the simplify-slave-addr branch 3 times, most recently from bed9ba8 to 6143858 Compare January 19, 2024 14:14
@coveralls
Copy link

coveralls commented Jan 29, 2024 •
edited
Loading

Coverage Status

coverage: 81.197% (-0.8%) from 81.974%
when pulling 0fb3ca0 on reitermarkus:simplify-slave-addr
into 698c817 on eldruin:master.

@reitermarkus
Copy link
Contributor Author

@eldruin, can you have a look here?

eldruin
eldruin reviewed Feb 13, 2024
View reviewed changes
Copy link
Owner

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!
Default vs. alternative addresses is a very common nomenclature for I2C device addresses

CHANGELOG.md Outdated Show resolved Hide resolved
@eldruin eldruin merged commit 0ff4c7b into eldruin:master Feb 13, 2024
2 checks passed
@reitermarkus reitermarkus deleted the simplify-slave-addr branch February 19, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reitermarkus @coveralls @eldruin