Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make time series start and end time settings required settings #98833

Open
martijnvg opened this issue Aug 24, 2023 · 2 comments
Open

Make time series start and end time settings required settings #98833

martijnvg opened this issue Aug 24, 2023 · 2 comments

Comments

@martijnvg
Copy link
Member

martijnvg commented Aug 24, 2023

The index.time_series.start_time and index.time_series.end_time settings are required for tsdb backing indices of a data stream. However for standalone tsdb indices these settings are optional with somewhat extreme default values, 01-01--9999 and 31-12-9999 respectively. I suspect this was done for ease of testing tsdb functionality in a standalone index.

For tsdb data streams it shouldn't currently be possible to get into a situation that a backing index has no index.time_series.start_time or index.time_series.end_time settings. However in the past it was possible due a bug and I don't think it is watertight. I think we need also need to make index.time_series.start_time and index.time_series.end_time settings required when defining tsdb indices. This would make the tsdb data stream validation easier and less error prone.

Found as part of investigating #98792

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@elasticsearchmachine elasticsearchmachine added Team:StorageEngine and removed Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Feb 12, 2024
@martijnvg martijnvg changed the title Validate the time series start and end time settings are configured. Make time series start and end time settings required settings Feb 12, 2024
@salvatore-campagna salvatore-campagna removed their assignment Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants