-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could DataStreamTimestampFieldMapper not iterate over all fields? #92297
Labels
Comments
Pinging @elastic/es-search (Team:Search) |
+1. I tried a while ago to make |
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Description
DataStreamTimestampFieldMapper#postParse
scans over all fields that have been created during the parsing process to verify that there is exactly one@timestamp
field. This even happens twice with the TSDB mode becauseTsidExtractingFieldMapper#createField
does another pass to extract the timestamp that it needs to generate the ID.Could we instead hook into the parsing logic of
DateFieldMapper#parse
to record the timestamp value of the document somewhere on theLuceneDocument
so that it's ready to use forDataStreamTimestampFieldMapper#postParse
andTsidExtractingFieldMapper#createField
and we don't have to scan over fields again?The text was updated successfully, but these errors were encountered: