You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A user creates a transform with deprecated syntax or the syntax gets deprecated at a later time. GETshould return deprecation warnings for painless scripts, so he can fix the script (for repro steps see #82935).
When parsing the transform configs, scripts aren't evaluated. GET does not return deprecation warnings.
Decision: Script compilation makes the call more expensive, despite script caching. If a GET targets all, we have to do a lot of compilation. At the moment we've decided that this is out of scope.
However the deprecation info API (TransformDeprecationChecker) should return deprecations, therefore compile scripts if necessary. The deprecation warnings should appear in the kibana upgrade assistant in 7.17.
Note: We need to discuss named scripts, they should probably handled directly by the deprecation info API, but not triggered from transform.
Target: This should go into the latest main branch and 7.17 to mainly fix the upgrade experience(7.17) but also have everything in place for future deprecations(main).
The text was updated successfully, but these errors were encountered:
hendrikmuhs
changed the title
[Transform] return deprecation warnings for painless scripts on GET and TransformDeprecationChecker
[Transform] return deprecation warnings for painless scripts in TransformDeprecationChecker
Jan 26, 2022
Related to #82935:
A user creates a transform with deprecated syntax or the syntax gets deprecated at a later time.
GET
should return deprecation warnings for painless scripts, so he can fix the script (for repro steps see #82935).When parsing the transform configs, scripts aren't evaluated.
GET
does not return deprecation warnings.Decision: Script compilation makes the call more expensive, despite script caching. If a
GET
targets all, we have to do a lot of compilation. At the moment we've decided that this is out of scope.However the deprecation info API (
TransformDeprecationChecker
) should return deprecations, therefore compile scripts if necessary. The deprecation warnings should appear in the kibana upgrade assistant in7.17
.Note: We need to discuss named scripts, they should probably handled directly by the deprecation info API, but not triggered from transform.
Target: This should go into the latest main branch and 7.17 to mainly fix the upgrade experience(7.17) but also have everything in place for future deprecations(main).
The text was updated successfully, but these errors were encountered: