Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform] return deprecation warnings for painless scripts in TransformDeprecationChecker #82936

Open
hendrikmuhs opened this issue Jan 24, 2022 · 1 comment
Labels
>bug :ml/Transform Transform Team:ML Meta label for the ML team

Comments

@hendrikmuhs
Copy link
Contributor

hendrikmuhs commented Jan 24, 2022

Related to #82935:

A user creates a transform with deprecated syntax or the syntax gets deprecated at a later time. GETshould return deprecation warnings for painless scripts, so he can fix the script (for repro steps see #82935).

When parsing the transform configs, scripts aren't evaluated. GET does not return deprecation warnings.

Decision: Script compilation makes the call more expensive, despite script caching. If a GET targets all, we have to do a lot of compilation. At the moment we've decided that this is out of scope.

However the deprecation info API (TransformDeprecationChecker) should return deprecations, therefore compile scripts if necessary. The deprecation warnings should appear in the kibana upgrade assistant in 7.17.

Note: We need to discuss named scripts, they should probably handled directly by the deprecation info API, but not triggered from transform.

Target: This should go into the latest main branch and 7.17 to mainly fix the upgrade experience(7.17) but also have everything in place for future deprecations(main).

@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Jan 24, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@hendrikmuhs hendrikmuhs changed the title [Transform] return deprecation warnings for painless scripts on GET and TransformDeprecationChecker [Transform] return deprecation warnings for painless scripts in TransformDeprecationChecker Jan 26, 2022
@przemekwitek przemekwitek self-assigned this Jan 27, 2022
@przemekwitek przemekwitek removed their assignment Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :ml/Transform Transform Team:ML Meta label for the ML team
Projects
None yet
Development

No branches or pull requests

3 participants