Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't store response in request cache if it is over a certain percentage of the cache size #17380

Closed
colings86 opened this issue Mar 29, 2016 · 3 comments
Labels
>enhancement help wanted adoptme :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team

Comments

@colings86
Copy link
Contributor

For very large responses storing the response in the request cache may evict large numbers of other cached responses and take up most of the cache size. We should not store responses in the request cache which are over a certain percentage of the total request cache size. We already do something similar to this for the filter cache,

@jpountz
Copy link
Contributor

jpountz commented Mar 29, 2016

+1

@colings86 colings86 added the :Search/Search Search-related issues that do not fall into other categories label Jun 25, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@jimczi jimczi added the help wanted adoptme label May 7, 2019
@rjernst rjernst added the Team:Search Meta label for search team label May 4, 2020
@javanna
Copy link
Member

javanna commented Jun 24, 2024

This has been open for quite a while, and hasn't had a lot of interest. For now I'm going to close this as something we aren't planning on implementing. We can re-open it later if needed.

@javanna javanna closed this as not planned Won't fix, can't repro, duplicate, stale Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement help wanted adoptme :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team
Projects
None yet
Development

No branches or pull requests

8 participants