Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: mv_sort should check and only allow certain values for order parameter #109910

Closed
astefan opened this issue Jun 19, 2024 · 1 comment · Fixed by #110021
Closed

ESQL: mv_sort should check and only allow certain values for order parameter #109910

astefan opened this issue Jun 19, 2024 · 1 comment · Fixed by #110021
Assignees
Labels
:Analytics/ES|QL AKA ESQL >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@astefan
Copy link
Contributor

astefan commented Jun 19, 2024

Description

Right now, mv_sort allows any kind of value to be placed in the optional order parameter.
This makes it hard for users to understand if the intention they had with the query is being met or not. Plus, if we change in the future the values we now allow in order to something else, the current behavior of silently (no error, no warning header) ignoring the faulty value and defaulting to "asc" will be a hidden breaking change.

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jun 19, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants