Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows client support #87

Closed
ekzhang opened this issue Apr 28, 2024 · 5 comments · Fixed by #99
Closed

Windows client support #87

ekzhang opened this issue Apr 28, 2024 · 5 comments · Fixed by #99
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ekzhang
Copy link
Owner

ekzhang commented Apr 28, 2024

(It looks like due to a bug or some other issue on GitHub, the previous issue for Windows support is not showing up, so I'm going to make a new one.)

The sshx client is mostly cross-platform, except one file terminal.rs. To add Windows support, we would need to port terminal.rs to Windows using the ConPTY API.
@ekzhang ekzhang added help wanted Extra attention is needed good first issue Good for newcomers labels Apr 28, 2024
@ekzhang ekzhang changed the title Windows support Windows client support May 1, 2024
@thewh1teagle
Copy link

Hey!
What's the status of this feature?

@ekzhang
Copy link
Owner Author

ekzhang commented Jul 21, 2024

You're welcome to help implement it! It's the same as before.

@wll8
Copy link

wll8 commented Aug 23, 2024

Super looking forward to implementing it on Windows

@ekzhang
Copy link
Owner Author

ekzhang commented Aug 23, 2024

Me too! Please give me a holler if you'd like to work on it

@ekzhang ekzhang mentioned this issue Sep 7, 2024
Merged
@ekzhang
Copy link
Owner Author

ekzhang commented Sep 8, 2024

I had some time today and am mostly caught up on emails, so I went ahead and spun up a Windows VM on AWS and made a dev environment. Such a pain to even set up SSH compared to Linux! But that's what it is, remote desktop protocol and so on.

There is a PR #99 that adds Windows support to sshx. Please test and let me know if it works for you. You can build within the branch with cargo run -p sshx. Thanks!

I'm especially interested in hearing if the shell detection is working right. Powershell doesn't seem to be launching, besides that I'm just auto-detecting for git bash and cmd right now. Anything else people use commonly / stats about this? Cygwin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Windows support for sshx ekzhang/sshx
3 participants
@ekzhang @wll8 @thewh1teagle