Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor interfaces into appropriate namespaces #152

Closed
ekolis opened this issue Jan 23, 2021 · 0 comments · Fixed by #301
Closed

Refactor interfaces into appropriate namespaces #152

ekolis opened this issue Jan 23, 2021 · 0 comments · Fixed by #301
Assignees
@ekolis
Labels
breaking This change will break savegame compatibility. technical debt Things that would make the code cleaner but deliver little to no value to users.
Milestone
alpha-10

Comments

@ekolis
Copy link
Owner

ekolis commented Jan 23, 2021

What needs to be cleaned up?

All the game's interfaces live in their own namespace; it would make more sense to place them in namespaces with their related classes.

How will this benefit us?

Don't need to go importing the interfaces namespace everywhere.
@ekolis ekolis added the technical debt Things that would make the code cleaner but deliver little to no value to users. label Jan 23, 2021
@ekolis ekolis added this to the future milestone Jan 23, 2021
@ekolis ekolis added the breaking This change will break savegame compatibility. label Feb 8, 2021
@ekolis ekolis self-assigned this Feb 10, 2024
@ekolis ekolis modified the milestones: future, alpha-10 Feb 10, 2024
@ekolis ekolis linked a pull request Feb 10, 2024 that will close this issue
Refactor interfaces and enumerations into appropriate namespaces #301
Merged
@ekolis ekolis mentioned this issue Feb 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ekolis ekolis

Labels
breaking This change will break savegame compatibility. technical debt Things that would make the code cleaner but deliver little to no value to users.
Projects
FrEee Core
Status: Done
FrEee WinForms GUI
Status: Done
Milestone
alpha-10
Development

Successfully merging a pull request may close this issue.

Refactor interfaces and enumerations into appropriate namespaces ekolis/FrEee
1 participant
@ekolis