Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Exclude authors. #5

Closed
GoogleCodeExporter opened this issue Aug 23, 2015 · 8 comments
Closed

Feature request: Exclude authors. #5

GoogleCodeExporter opened this issue Aug 23, 2015 · 8 comments

Comments

@GoogleCodeExporter
Copy link

I'd be great to have an option to exclude some authors from statistics... 
especially when you want to grade a student project that is based on some 
existing repository, and you only want to see the commits of a specified group 
of people.

Unfortunately I can't implement that myself... but maybe someone else will also 
be interested, and will do necessary changes.

Original issue reported on code.google.com by [email protected] on 19 Jun 2013 at 11:46

@GoogleCodeExporter
Copy link
Author

I like the idea and I think it would be a great feature to add.

Gitinspector already has the -x/--exclude flag for excluding files that match a 
certain string/name (it can be specified multiple times). How about expanding 
that so one could do something like this:

gitinspector.py -x="author:John Smith" -x "author:Robert Brown"

This way; -x could also be expanded in the future to include other types of 
exclusion patterns.

However, implementing it that way does bring up a conundrum; What happens with 
very big repositories that have many (for example 100) authors? Specifying it 
some ~100 times isn't my idea of a good time. Maybe it's time for a 
-i/--include flag also?  My thinking is that -i/-x could be specified multiple 
times in different variations to create different matching rules.

In that case it would be a matter of doing something like this:

gitinspector.py -x "author:*" -i "author:James Johnsson" -i "author:Michael 
Davids"

The idea is that the above would exclude all authors but include "James 
Johnsson" and "Michael Davids" in the statistics.

Maybe -x "author:*" should be the default behaviour if the first pattern 
matching rule is a -i "author:...", otherwise nothing would happen.

Tell me what you think and if you have any better ideas.

/Adam Waldenberg

Original comment by [email protected] on 20 Jun 2013 at 1:22

  • Changed state: Accepted
  • Added labels: Type-Enhancement
  • Removed labels: Type-Defect

@GoogleCodeExporter
Copy link
Author

In any case, I will look into this eventually. However, I will put it on hold 
until some time after the 0.3.0 release.

/Adam Waldenberg

Original comment by [email protected] on 30 Jun 2013 at 4:43

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 30 Jun 2013 at 6:44

  • Added labels: Milestone-Release0.4.0

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 20 Jul 2013 at 8:31

  • Added labels: Priority-Low
  • Removed labels: Priority-Medium

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 29 Jul 2013 at 10:46

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

This issue was closed by revision 1edae66fee4f.

Original comment by [email protected] on 30 Jul 2013 at 4:34

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Done. Please repport any problems you may encounter. For documentation on how 
to use this; see the revision referenced above

/Adam Waldenberg

Original comment by [email protected] on 30 Jul 2013 at 4:38

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 13 Jan 2014 at 11:00

  • Added labels: Milestone-Release0.3.2
  • Removed labels: Milestone-Release0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants