Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitinspector --metrics errs out on paths with spaces #47

Closed
GoogleCodeExporter opened this issue Aug 23, 2015 · 5 comments
Closed

gitinspector --metrics errs out on paths with spaces #47

GoogleCodeExporter opened this issue Aug 23, 2015 · 5 comments

Comments

@GoogleCodeExporter
Copy link

> What steps will reproduce the problem?
1. have a git repo with spaces in its paths
2. invoke gitinspector.py --metrics /path/to/repo

> What is the expected output? What do you see instead?
The normal output of --metrics. I see instead:
fatal: Path 'other' does not exist in 'HEAD'
fatal: Path 'files/go_here' does not exist in 'HEAD'

> What version of the product are you using?
0.3.2

> What version of Python?
Python 2.7.8

> On what operating system?
Linux Debian/sid

Patch shows the necessary diff to make it handle "other files/go_here".

Original issue reported on code.google.com by [email protected] on 17 Nov 2014 at 10:44

@GoogleCodeExporter
Copy link
Author

Hi. Gitinspector will be able to handle multiple repositories at some point 
(and group them together). What you are seeing doesn't really relate to 
gitinspector - it's related to the terminal. If you want to pass something as 
one path when invoking gitinspector from the terminal, just do the following:

gitinspector.py --metrics "/other files/go_here"

Also, This patch would break terminals that don't use '"' to group arguments 
together.

/Adam Waldenberg

Original comment by [email protected] on 19 Nov 2014 at 6:19

  • Changed state: Invalid

@GoogleCodeExporter
Copy link
Author

I agree the problem is with the terminal.
However, it's not the /path/to/repo that contains spaces.
It's files inside that repo (that have spaces in their filename) that break 
gitinspector.py

Therefore I think it's a very valid bug :-)

Original comment by [email protected] on 20 Nov 2014 at 8:11

@GoogleCodeExporter
Copy link
Author

Aha. That makes more sense... Sorry.

I'm actually doing something similar in blame.py and it seems to be working for 
most users (and terminals ;)).

/Adam Waldeneberg

Original comment by [email protected] on 21 Nov 2014 at 1:45

  • Changed state: Started
  • Added labels: Priority-Critical
  • Removed labels: Priority-Medium

@GoogleCodeExporter
Copy link
Author

This issue was closed by revision dd50994f2c4c.

Original comment by [email protected] on 21 Nov 2014 at 1:56

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Issue 56 has been merged into this issue.

Original comment by [email protected] on 9 Feb 2015 at 4:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants