Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add convenience method to clone WanetBackdoor instance #34

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Add convenience method to clone WanetBackdoor instance #34

merged 2 commits into from
Mar 4, 2024

Conversation

VRehnberg
Copy link
Collaborator

This is basically how I would've used WanetBackdoors as objects. I have no strong opinions on any details of this is done, but it would be nice to have something at least.

@VRehnberg VRehnberg mentioned this pull request Mar 4, 2024
Merged
@VRehnberg
Copy link
Collaborator Author

Depends on #30

@ejnnr
Copy link
Owner

ejnnr commented Mar 4, 2024

  • Removed duplicate dataclass fields, I assume that was just a leftover from prototyping
  • I also removed the path argument to clone(); I think there's no reason to pass one in as we'll override the control grid anyway, so I thought it might just be confusing to even have the argument. Happy to undo that if I'm missing something

@ejnnr ejnnr merged commit f7e9300 into ejnnr:no-configs Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VRehnberg @ejnnr