Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeInstaller is not copying the npm binaries next to the node exec #1152

Open
ia3andy opened this issue Jun 7, 2024 · 0 comments · May be fixed by #1153
Open

NodeInstaller is not copying the npm binaries next to the node exec #1152

ia3andy opened this issue Jun 7, 2024 · 0 comments · May be fixed by #1153

Comments

@ia3andy
Copy link

ia3andy commented Jun 7, 2024

This causes package.json script using npm to yield: npm command not found, because it is not in the PATH.

There is a comment saying it does, but it's is not actually done:
https://github.com/eirslett/frontend-maven-plugin/blob/master/frontend-plugin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/NodeInstaller.java#L192

It works when using the NPMInstaller because it actually does it:
https://github.com/eirslett/frontend-maven-plugin/blob/master/frontend-plugin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/NPMInstaller.java#L182-L205

@ia3andy ia3andy changed the title NodeInstaller is not copying the binaries next to the node exec NodeInstaller is not copying the npm binaries next to the node exec Jun 7, 2024
melloware added a commit to melloware/frontend-maven-plugin that referenced this issue Jun 7, 2024
@melloware melloware linked a pull request Jun 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant