-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
if upgrading, first delete the full "node" dir #994
Comments
I can confirm that upgrading from 14.17.0 to 16.13.1 fails when running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
when i did go from Node 16.2 to 1.6.6 it did do the update to that version
(this is with npm just included, not an extra npm install)
but then weird npm-cli errors came up
when i then really just first delete the "node" dir and let the plugin install node again everything was fine
if i look into:
https://github.com/eirslett/frontend-maven-plugin/blob/master/frontend-plugin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/NodeInstaller.java
i also don't really see a full delete first..
NpmInstaller i do see that that it first does delete stuff.
But not when npm is provided by node i think it is this code:
https://github.com/eirslett/frontend-maven-plugin/blob/master/frontend-plugin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/NodeInstaller.java#L189
are we needing there 1 line of code that deletes first if it is there the full target dir?
The text was updated successfully, but these errors were encountered: