From 5e0a7d8025df52e001b3a387c67207aae2730bb4 Mon Sep 17 00:00:00 2001 From: Manu Bretelle Date: Fri, 20 Oct 2023 21:11:51 -0700 Subject: [PATCH] [bcc test] Simplify workflow During the bcc-test workflow, we do not really need `installed_llvm_versions` as we only need to build the ephemeral container for the llvm version we are testing (e.g matrix.llvm_version). This container is only built IFF a docker file is changed in order to make sure the PR runs on a container which has the changes from the docker file. At the end of the day, the container that we use only needs 1 llvm version installed, the one we test. --- .github/workflows/bcc-test.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/bcc-test.yml b/.github/workflows/bcc-test.yml index 227ecb7eb17e..0f3a12319b6a 100644 --- a/.github/workflows/bcc-test.yml +++ b/.github/workflows/bcc-test.yml @@ -21,7 +21,7 @@ jobs: runs-on: ubuntu-20.04 strategy: matrix: - os: [{distro: "ubuntu", version: "18.04", nick: bionic, installed_llvm_versions: "11 12"}, {distro: "ubuntu", version: "20.04", nick: focal, installed_llvm_versions: "11 12 15"}] + os: [{distro: "ubuntu", version: "18.04", nick: bionic}, {distro: "ubuntu", version: "20.04", nick: focal}] llvm_version: [11, 12, 15] env: - TYPE: Debug @@ -34,7 +34,7 @@ jobs: PYTHON_TEST_LOGFILE: critical.log RW_ENGINE_ENABLED: ON exclude: - - os: {distro: "ubuntu", version: "18.04", nick: bionic, installed_llvm_versions: "11 12"} + - os: {distro: "ubuntu", version: "18.04", nick: bionic} llvm_version: 15 steps: - uses: actions/checkout@v2 @@ -59,7 +59,7 @@ jobs: os_distro: ${{ matrix.os.distro }} os_version: ${{ matrix.os.version }} os_nick: ${{ matrix.os.nick }} - llvm_versions: ${{ matrix.os.installed_llvm_versions }} + llvm_versions: ${{ matrix.llvm_version }} - name: Tag docker container run: | docker tag ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ matrix.os.distro }}-${{ matrix.os.version }} bcc-docker