Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown performance #255

Closed
slavik990 opened this issue Aug 17, 2017 · 1 comment
Closed

Dropdown performance #255

slavik990 opened this issue Aug 17, 2017 · 1 comment
Assignees
@edcarroll
Labels
comp: dropdown priority: important type: bug
Milestone
0.9.6

Comments

@slavik990
Copy link

We have a lot of dropdown on page, and same as in #194 we have problem with performance. It reproducible when input any text, https://plnkr.co/edit/n9kJ8cerRpX4yBFDinXQ?p=preview.
Seems it because @HostListener("document:keydown", ["$event"]) at file https://github.com/edcarroll/ng2-semantic-ui/blob/master/src/modules/dropdown/directives/dropdown-menu.ts
@edcarroll edcarroll added this to the 0.9.6 milestone Aug 17, 2017
@edcarroll edcarroll self-assigned this Aug 17, 2017
@edcarroll edcarroll mentioned this issue Aug 19, 2017
Merged
@edcarroll
Copy link
Owner

This is now live in 0.9.6 😄 I decided to turn all of the document @HostListeners into manual listeners to avoid this issue on other components in the future. Let me know if you still have any problems!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edcarroll edcarroll

Labels
comp: dropdown priority: important type: bug
Projects
None yet
Milestone
0.9.6
Development

No branches or pull requests
2 participants
@slavik990 @edcarroll