Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platformApi): fix wrong expression for extracting the font size #968

Merged
merged 2 commits into from
Nov 13, 2022

Conversation

plainheart
Copy link
Collaborator

@plainheart plainheart commented Oct 24, 2022

Fix #947
Fix apache/echarts#17326

The font string might be composed as normal normal 12px sans-serif via the Text#makeFont function. So the ^ and $ should be removed from the expression.

Before After
image image

@plainheart plainheart changed the title fix(platformApi): fix wrong regexp for extracting the font size fix(platformApi): fix wrong expression for extracting the font size Oct 24, 2022
@plainheart plainheart merged commit b952ca1 into master Nov 13, 2022
@plainheart plainheart deleted the fix-measure-text branch November 13, 2022 04:42
@zhiqingchen
Copy link

hi @plainheart
Is there a plan to publish the changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants