New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(svg): fix shared vnode in pattern brings render issue #889

Merged

pissang merged 1 commit into master from fix-svg-pattern

Feb 9, 2022

Contributor

pissang commented Feb 9, 2022

The vnode svgElement may be shared by multiple patterns because the cache strategy in https://github.com/apache/echarts/blob/master/src/util/decal.ts#L121. It may cause render issue like described in apache/echarts#16449. This PR clones the svgElement to make sure each vnode is unique.


fix(svg): fix shared vnode in pattern brings render issue

1ad0202

pissang requested a review from plainheart

February 9, 2022 04:45

plainheart approved these changes

View reviewed changes

pissang merged commit e25b110 into master

pissang deleted the fix-svg-pattern branch

February 9, 2022 13:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment