fix(svg): fix assigning style attribute does not work when CSP is enforced #1030
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apache/echarts#16610
Overview
This pull request addresses a specific limitation concerning Content Security Policy (CSP). When CSP is enabled, direct assignments to an element's style property using a string are disallowed. However it is possible to use
element.style.cssText = ...
instead.Reproduction
Create and open an HTML file with the following content:
In the console you should see the following error:
![Screen Shot 2023-09-18 at 4 18 47 PM](https://private-user-images.githubusercontent.com/14301985/268751407-2a6d5fc6-4ba8-43ba-b6a6-e1b13dcafcb3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE3MzE1MzcsIm5iZiI6MTcyMTczMTIzNywicGF0aCI6Ii8xNDMwMTk4NS8yNjg3NTE0MDctMmE2ZDVmYzYtNGJhOC00M2JhLWI2YTYtZTFiMTNkY2FmY2IzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIzVDEwNDAzN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTExYTdjYjA0MDkyM2ZiMmFiNGQ5NzRkMjE1YmQ2ZWU4NzJlZDc3YWE1Y2ZjZDkyZDRmMTljYmVjNTQ0ZmFmNzAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.IuMvcESZ7oZuIwFtGLhN1PNvEfKuOSW3Xk69jPqfii0)