-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup raster/sf use WIP #48
Comments
see https://github.com/diminutive/hackspatialcpp for some Cpp that gets what we need from sf the removal is now merged into master with #52 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
tentatively , I'll just sit on this a while but see branch remove-raster-method
need to determine sensible crs behaviour (we were copying the sf$crs$proj4string to r@crs when using raster(sf))
situations are
-[x] input sf has NA crs, do nothing
-[x] input sf has crs, input raster has NA crs ,do nothing
-[ ] input sf has crs, input raster has crs and they are different
-[x] input sf has crs, input raster has crs and they are same, do nothing
the only thing to do is st_transform when both are set but different, but do we check if there's wkt/projstring in the raster?
The text was updated successfully, but these errors were encountered: