Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize & apply standard formatting #152

Closed
askarbozcan opened this issue Mar 27, 2023 · 7 comments · Fixed by #325
Closed

Standardize & apply standard formatting #152

askarbozcan opened this issue Mar 27, 2023 · 7 comments · Fixed by #325

Comments

@askarbozcan
Copy link
Contributor

In a lot of places in the code, there's a weird mix of tabs & spaces, causing function bodies not to be indented correctly.

For an example, see LazySessionHandler.java

It seems that tab size is assumed to be 8 spaces, but then again in a lot places 4 spaces are used for indentation.

I propose adding a convention for the project's code, and perhaps a code formatter (perhaps as a Maven plugin?)

@jfaltermeier
Copy link
Collaborator

jfaltermeier commented Mar 28, 2023

Makes sense. Currently the Java projects should have some project-specific files checked in for the Eclipse IDE. We should make this IDE independent.
Probably we should also add some checks to the verification build.

@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added the stale label Jun 26, 2023
@sgraband

This comment was marked as outdated.

@github-actions github-actions bot removed the stale label Jun 27, 2023

This comment was marked as outdated.

@github-actions github-actions bot added the stale label Dec 25, 2023
@jfaltermeier

This comment was marked as outdated.

@github-actions github-actions bot removed the stale label Jan 2, 2024

This comment was marked as outdated.

@github-actions github-actions bot added the stale label Jun 30, 2024

This comment was marked as outdated.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 15, 2024
@jfaltermeier jfaltermeier reopened this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants