Enhance static library build #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lancechentw
commented
May 31, 2016
- Fix a build fail which is caused by a lack of source object in libmosquitto.
- Add an CMake option BUILD_STATIC_LIBRARY to allow control over building static libraries or not.
- Add an CMake option WITH_PIC to allow control over building static libraries with PIC or not.
- Add build configuration to build CPP static library.
The shared library fails to link to `handle*` functions implementd in lib/handle_* because these source file definitions seem to be removed accidentally in commit 3499c09. Signed-off-by: Lance Chen <[email protected]>
The BUILD_STATIC_LIBRARY option is default to ON. Signed-off-by: Lance Chen <[email protected]>
The option WITH_PIC is default to OFF. By default, the static library is built from the source code directly. If WITH_PIC is enabled, the static library is built with the same set of object libraries that the shared library uses. To link Mosquitto static library into a shared library, one must enable WITH_PIC to make the piece of code locatable. Signed-off-by: Lance Chen <[email protected]>
The CPP static library respects options BUILD_STATIC_LIBRARY and WITH_PIC as well. Signed-off-by: Lance Chen <[email protected]>
|
I was wondering if you guys prefer
This pull request goes with 1) |
|
I don't have any strong feelings on the CPP library, let's see if anybody else chimes in. Thanks, this generally looks good, I'll give it a test later. |
to conform to the bare Makefiles Signed-off-by: Lance Chen <[email protected]>
f2fcd86
to
97847fa
Compare
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.