Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add socket headers for FreeBSD #977

Merged
merged 1 commit into from Nov 7, 2018
Merged

Add socket headers for FreeBSD #977

merged 1 commit into from Nov 7, 2018

Conversation

iblislin
Copy link
Contributor

I got this on FreeBSD

/home/iblis/git/mosquitto/lib/socks_mosq.c:105:18: error: variable has incomplete type 'struct in6_addr'                                                                     
        struct in6_addr addr_ipv6;
                        ^
/home/iblis/git/mosquitto/lib/socks_mosq.c:105:9: note: forward declaration of 'struct in6_addr'                                                                             
        struct in6_addr addr_ipv6;
               ^
/home/iblis/git/mosquitto/lib/socks_mosq.c:149:32: error: use of undeclared identifier 'AF_INET'                                                                             
                ipv4_pton_result = inet_pton(AF_INET, mosq->host, &addr_ipv4);
                                             ^
/home/iblis/git/mosquitto/lib/socks_mosq.c:150:32: error: use of undeclared identifier 'AF_INET6'                                                                            
                ipv6_pton_result = inet_pton(AF_INET6, mosq->host, &addr_ipv6);

@karlp
Copy link
Contributor

karlp commented Sep 30, 2018

people have been building mosuqitto on netbsd/freebsd/openbsd for years, is there something particualr in your environment that is making this pop up now? Did you just change your libc or anything?

@iblislin
Copy link
Contributor Author

I'm upgrading FreeBSD ports from 1.4.13 to 1.5.3.

I just upstream this patch.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231047

@iblislin
Copy link
Contributor Author

1.5.1 can build without this patch, but 1.5.3 not.

@ralight ralight added this to the 1.5.4 milestone Nov 6, 2018
@ralight
Copy link
Contributor

ralight commented Nov 6, 2018

I'd like to include this in the 1.5.4 release, the only thing holding me back is that you've not signed the Eclipse Contributor Agreement. You should read the whole thing, but it's essentially saying that you assert you have the right to contribute the code. If you would like to sign it, please just head over to https://accounts.eclipse.org/user/eca and do so, using the same email address as in the commit. There is no need to change the PR, just mention that you've signed and I'll manually make the check.

@iblislin
Copy link
Contributor Author

iblislin commented Nov 7, 2018

okay, I singed it.

@ralight
Copy link
Contributor

ralight commented Nov 7, 2018

Lovely! Thanks very much for keeping FreeBSD up to date.

@ralight ralight merged commit 0368a8c into eclipse:fixes Nov 7, 2018
@iblislin iblislin deleted the fixes branch November 7, 2018 10:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants