mqtt3_db_message_insert view online user queued message as 'insert failed'

[ralight]

migrated from Bugzilla #465399
status RESOLVED severity critical in component Mosquitto for 1.4
Reported in version 1.4 on platform PC
Assigned to: Roger Light

On 2015-04-24 06:11:35 -0400, henry john wrote:

database.c Line 340
////////////////////////////////////////////////
if(context->sock != INVALID_SOCKET){
if(qos == 0 || max_inflight == 0 || context->msg_count12 < max_inflight){
if(dir == mosq_md_out){
switch(qos){
case 0:
state = mosq_ms_publish_qos0;
break;
case 1:
state = mosq_ms_publish_qos1;
break;
case 2:
state = mosq_ms_publish_qos2;
break;
}
}else{
if(qos == 2){
state = mosq_ms_wait_for_pubrel;
}else{
return 1;
}
}
}else if(max_queued == 0 || context->msg_count12-max_inflight < max_queued){
state = mosq_ms_queued;
rc = 2; ? Is this line an error?
///////////////////////////////////////////////////////

On 2015-04-28 09:14:54 -0400, Roger Light wrote:

This is correct. A return value of 2 here means "the function succeeded, but don't process this message any further. It may indicate that the message was dropped.