lib: fix OpenSSL 1.1 deprecation warning for ERR_remove_state #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ERR_remove_state has been marked deprecated in OpenSSL 1.1.0 and do nothing, as the OpenSSL libraries now normally do all thread initialization and deinitialisation automatically. Signed-off-by: Jelle van der Waa <[email protected]>
|
Sorry for the delay! That looks pretty sensible, thanks. I've pushed your patch to the fixes branch instead so I'm closing this PR. |
|
fwiw, this is just prolonging the inevitable. ERR_remove_thread_state is also deprecated! Also, building with openssl 1.0.2 with deprecated apis turned off still fails, because the version is ok, but not the compat API. It's too gross to "fix" properly for me right now, but just an FYI for later.... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ERR_remove_state has been marked deprecated in OpenSSL 1.1.0 and do
nothing, as the OpenSSL libraries now normally do all thread
initialization and deinitialisation automatically.