Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mosquitto doesn't build in parallel mode #39

Closed
ralight opened this issue Mar 15, 2016 · 0 comments
Closed

mosquitto doesn't build in parallel mode #39

ralight opened this issue Mar 15, 2016 · 0 comments

Comments

@ralight
Copy link
Contributor

ralight commented Mar 15, 2016

migrated from Bugzilla #463884
status RESOLVED severity normal in component Mosquitto for 1.4
Reported in version 1.4 on platform PC
Assigned to: Roger Light

On 2015-04-03 07:10:12 -0400, Gianfranco Costamagna wrote:

The patch is attached, just a problem with cmake doesn't make it handle correctly the mosquitto dependency

diff --git a/lib/cpp/CMakeLists.txt b/lib/cpp/CMakeLists.txt
index 68b1453..0a9fd91 100644
--- a/lib/cpp/CMakeLists.txt
+++ b/lib/cpp/CMakeLists.txt
@@ -5,7 +5,7 @@ link_directories(${mosquitto_BINARY_DIR}/lib)
add_library(mosquittopp SHARED
mosquittopp.cpp mosquittopp.h)

-target_link_libraries(mosquittopp mosquitto)
+target_link_libraries(mosquittopp libmosquitto)
set_target_properties(mosquittopp PROPERTIES
VERSION ${VERSION}
SOVERSION 1

On 2015-04-09 15:09:44 -0400, Roger Light wrote:

Thanks for the patch. Could you please add a comment stating that you comply with the terms here: http:https://www.eclipse.org/legal/CoO.php

After you have done this I can accept the patch.

On 2015-04-09 15:16:52 -0400, Gianfranco Costamagna wrote:

Yes, you have my permission, and I comply with the terms.

cheers,

G.

On 2015-04-11 07:16:06 -0400, Roger Light wrote:

This will be fixed in 1.4.2, thanks for the patch.

On 2015-05-20 04:57:34 -0400, Gianfranco Costamagna wrote:

thanks to you!

@ralight ralight closed this as completed Mar 15, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant