Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly missing calls to ENGINE_free in net__load_engine on error condition #3034

Open
Kitty-Hawk1 opened this issue Apr 8, 2024 · 0 comments

Comments

@Kitty-Hawk1
Copy link

Linux - 4e6fbae. But seen on master

When using an openssl engine with a secure element, it has been noticed that very occasionally it fails, and after which mosquitto can't be used as the openssl engine thinks it's already in use.

Not familiar with opesnssl engine but I think to make it recover, the following is required:

in net__load_engine()

calls ENGINE_init << if the call fails it should call ENGINE_free before returning

similarly ENGINE_load_private_key << if the call fails it should call ENGINE_free before returning

and SSL_CTX_use_PrivateKey << if the call fails it should call ENGINE_free before returning

and finally ENGINE_ctrl_cmd << if the call fails it should call ENGINE_free before returning

Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant