[PATCH] Crossing compile websockets.c

[ralight]

migrated from Bugzilla #475807
status RESOLVED severity normal in component Mosquitto for 1.4
Reported in version 1.4 on platform PC
Assigned to: Roger Light

On 2015-08-25 09:06:03 -0400, Tyler Brandon wrote:

diff --git a/src/Makefile b/src/Makefile
index 2cfb7d4..2bc70de 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -90,7 +90,7 @@ util_mosq.o : ../lib/util_mosq.c ../lib/util_mosq.h
${CROSS_COMPILE}${CC} $(BROKER_CFLAGS) -c $< -o $@

websockets.o : websockets.c mosquitto_broker.h

•   ${CC} $(BROKER_CFLAGS) -c $< -o $@
  

•   ${CROSS_COMPILE}${CC} $(BROKER_CFLAGS) -c $< -o $@
  

  will_mosq.o : ../lib/will_mosq.c ../lib/will_mosq.h
  ${CROSS_COMPILE}${CC} $(BROKER_CFLAGS) -c $< -o $@

On 2015-09-16 16:04:26 -0400, Roger Light wrote:

*** Bug 475808 has been marked as a duplicate of this bug. ***

On 2015-09-16 16:15:03 -0400, Roger Light wrote:

Thanks, this was fixed in the develop branch but I'm not sure why I didn't get it into the last bugfix release.

I've committed a fix for it.

On 2015-10-03 12:25:59 -0400, testato testato wrote:

today i installed last Mosquitto 1.4.4 on a Xubuntu distribution whitout problem. Websocket connection work

But I install also on a CentOS server, using mosquitto official repo, and when i start Mosquitto i receive this message in the terminal:

mosquitto -c /etc/mosquitto/mosquitto.conf
Error: Websockets support not available.
Error found at /etc/mosquitto/mosquitto.conf:14.
Error: Unable to open configuration file.

I tried removing the websocket from config file and it work on standard mqtt portocol

Is it related to this Bug ?

On 2015-10-03 18:52:32 -0400, Roger Light wrote:

No, it is not related to this bug.

I'm afraid that the packages for CentOS do not provide websockets support because the required library (libwebsockets) isn't available in CentOS.

On 2015-10-04 05:31:30 -0400, testato testato wrote:

but is it possible compile and install it,
so why not enable in mosquitto the websocket option ?
the people that need websocket on CentOS must only recompile the libwebsocket, and can use directly the mosquitto stable 1.4.4 package without touch it.

Do you think it is better open an issue ? where i must open it ?

Thanks