Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always close file descriptors when deamonised. #2708

Closed
wants to merge 1 commit into from

Conversation

ckoehne
Copy link

@ckoehne ckoehne commented Dec 16, 2022

Assertions can be removed in debug builds.

Fixes: f588075
Signed-off-by: Corvin Köhne [email protected]

Thank you for contributing your time to the Mosquitto project!

Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.

Then please check the following list of things we ask for in your pull request:

  • Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.
  • If you are contributing a new feature, is your work based off the develop branch?
  • If you are contributing a bugfix, is your work based off the fixes branch?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run make test with your changes locally?

Assertions can be removed in debug builds.

Fixes: f588075
Signed-off-by: Corvin Köhne <[email protected]>
@ralight
Copy link
Contributor

ralight commented Dec 16, 2022

Thank you, you're quite right. I've fixed this in a slightly different way so the return values aren't ignored.

ralight added a commit that referenced this pull request Dec 16, 2022
This could occur when built with assertions removed.

Closes #2708. Thanks to ckoehne.
@ralight ralight closed this Dec 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants