-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep alive 0 results in 'identifier rejected' #2309
Comments
I face the same issue while integrating with Telegraf mqtt output plugin. |
This is a duplicate of #2117 which is now fixed in the |
I'm not so sure about that. I think that the change that was prompted by #2117 introduced another bug for v3 protocol. If I'm not mistaken, current code will still prevent any v3 client from connecting with 0 keep alive. |
or is the point here that you should set "max_keepalive" to 0 in the config file to allow clients disabling the functionality?
|
closing this. |
I just did an upgrade from 2.0.11 to 2.0.12 and noticed that some of my clients started to get "identifier rejected".
After some tracing i managed to narrow it down to this check.
mosquitto/src/handle_connect.c
Lines 265 to 266 in 42acfda
And only for v3 clients it looks like.
Apparently some of my clients have the maximum keep alive interval, so the check fails and throws them out.I'm wondering if the check technically shouldn't be a>=
?Of course. I'll just reconfigure my clients to use a lower keep alive since i can't put a higher max keep alive in config.It's an edge case since it's probably better to use a lower keep alive anyway, but felt it was a good idea to point it out.Edit:
Sorry, was thinking too fast.
Found other clients with keep alive interval 0 which results in 'identifier rejected'.
Looks like the spec has something to say about this:
With further digging i found #2117.
The text was updated successfully, but these errors were encountered: