Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installation fails when WITH_TLS=no #2281

Closed
mattst88 opened this issue Aug 19, 2021 · 2 comments
Closed

Installation fails when WITH_TLS=no #2281

mattst88 opened this issue Aug 19, 2021 · 2 comments
Labels
Component: build Related to the Makefiles / build scripts in the project. Status: Completed Nothing further to be done with this issue, it can be closed by the requestor or committer. Type: Bug
Milestone
2.0.12

Comments

@mattst88
Copy link

Reported in the Gentoo bugzilla: https://bugs.gentoo.org/806244

Installation fails when WITH_TLS is set to no because mosquitto_passwd is not built, but is unconditionally installed.

apps/mosquitto_passwd/Makefile contains:

ifeq ($(WITH_TLS),yes)
all: mosquitto_passwd
else
all:
endif
[...]
install : all
	$(INSTALL) -d "${DESTDIR}$(prefix)/bin"
	$(INSTALL) ${STRIP_OPTS} mosquitto_passwd "${DESTDIR}${prefix}/bin/mosquitto_passwd"

uninstall :
	-rm -f "${DESTDIR}${prefix}/bin/mosquitto_passwd"
@ralight ralight added Component: build Related to the Makefiles / build scripts in the project. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug labels Aug 20, 2021
@ralight ralight added Status: Completed Nothing further to be done with this issue, it can be closed by the requestor or committer. and removed Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. labels Aug 20, 2021
@ralight
Copy link
Contributor

ralight commented Aug 20, 2021

Thanks @mattst88, that should be fixed in the fixes branch now, and will be part of 2.0.12 soon.

@mattst88
Copy link
Author

Thank you very much, and sorry for not providing a patch myself!

@ralight ralight added this to the 2.0.12 milestone Aug 31, 2021
@ralight ralight closed this as completed in 342aa0a Sep 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Component: build Related to the Makefiles / build scripts in the project. Status: Completed Nothing further to be done with this issue, it can be closed by the requestor or committer. Type: Bug
Projects
None yet
Milestone
2.0.12
Development

No branches or pull requests
2 participants
@ralight @mattst88