Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mosquitto_loop_stop() hangs on Windows. #1748

Closed

Conversation

SigmundVik
Copy link
Contributor

Before this commit, mosquitto_loop_forever() would not always
terminate on Windows when calling mosquitto_loop_stop() with
the force flag set to true.

This commit adds explicit thread cancellation points in
mosquitto_loop_forever() as described in issue #117 to
ensure that mosquitto_loop_stop() does not hang when
joining the Mosquitto thread.

Closes #117.

Signed-off-by: Sigmund Vik [email protected]

  • Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.
  • If you are contributing a new feature, is your work based off the develop branch?
  • If you are contributing a bugfix, is your work based off the fixes branch?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run make test with your changes locally?

Before this commit, mosquitto_loop_forever() would not always
terminate on Windows when calling mosquitto_loop_stop() with
the force flag set to true.

This commit adds explicit thread cancellation points in
mosquitto_loop_forever() as described in issue eclipse#117 to
ensure that mosquitto_loop_stop() does not hang when
joining the Mosquitto thread.

Closes eclipse#117.

Signed-off-by: Sigmund Vik <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant