Async API never yields which causes the thread to eat CPU.

[nihilus]

The async API never yields which causes the thread to eat lots of CPU (about 99%). Adding usleep(10); to mosquitto_loop_misc() fixes this. However I am unsure if that is appropriate.

[karlp]

could you share a snippet of how you're using the apis?

[nihilus]

	mosq_ret = mosquitto_connect_async(mosq, ipstr, 1883, 0);
	if(mosq_ret != MOSQ_ERR_SUCCESS){
	    fprintf(stderr, "Unable to connect (%s)!\n", mosquitto_strerror(mosq_ret));
       	    goto exit;
        }

	mosq_ret = mosquitto_loop_start(mosq);
	if(mosq_ret != MOSQ_ERR_SUCCESS){
	    fprintf(stderr, "Unable to start loop (%s)!\n", mosquitto_strerror(mosq_ret));
       	    goto exit;
        }

	while(run == -1){
		nanosleep(&tv, NULL);
	}

[nihilus]

I will check if #1542 solves the issue tomorrow.

[ralight]

mosq_ret = mosquitto_connect_async(mosq, ipstr, 1883, 0);

You've set the keepalive parameter to 0 here. This should be rejected as an invalid value, but it isn't. I would suggest using a value of 10 as the absolute minimum value.

[nihilus]

Ah, explains.

[nihilus]

@ralight FWIW: Your suggestion worked perfectly. So the bug is that it doesn't validate the argument then.