DYS-173: Adding support for QNX7.0.0 #1018
Conversation
btaczala
force-pushed
the
qnx_fixes
branch
3 times, most recently
from
2e0c07d
to
80e6384
Compare
src/CMakeLists.txt
Outdated
| @@ -115,7 +115,10 @@ endif (WIN32 OR CYGWIN) | |||
|
|
|||
| add_definitions (-DWITH_BROKER) | |||
|
|
|||
| set (MOSQ_LIBS ${MOSQ_LIBS} ${OPENSSL_LIBRARIES}) | |||
| set (MOSQ_LIBS ${MOSQ_LIBS}) | |||
| if(WITH_TLS) | |||
There was a problem hiding this comment.
this seems like a standalone bug fix? ie, valid, but out of scope for a QNX support commit
There was a problem hiding this comment.
Ok, I'll create another PR for this
Change-Id: Id01e2880aa5cadc0e93a46b95fe675e1938051fa Signed-off-by: Bartosz Taczała <[email protected]>
|
looks sane to me, (one whitespace new line added) but I've not actually tested this or targetted qnx. More interestingly, do the makefiles work? the cmakefiles are, per readme, only intended for windows /mac "On Windows and Mac, use cmake to build. On other platforms, just run make to build." |
|
I'm happy to take this as is, thanks for the contribution. Way back in the day (around 2012) I compiled mosquitto for QNX, but haven't touched it since. It's nice to see some more interest from that side. Like Karl says, the bare Makefiles are intended as the canonical build scripts for the project, Mac and Windows not withstanding. I don't suppose it matters hugely, but it would be nice to hear if the build works with them as well. |
|
Oh.. Somehow I didn't catch that. |
|
There's nothing inherently wrong with using the cmake files, but the others are considered the best supported. For QNX I wouldn't worry particularly. |
This change allows mosquitto to be compiled and used on QNX platform (qnx700).
My custom CMake toolchain adds CMake variable
QNX; additionally qcc (QNX compiler) adds__QNX__macro that can be used in sources.Signed-off-by: Bartosz Taczała [email protected]
make testwith your changes locally?