From 6728c05a2cf89caa956a50392bb518d9588f63b4 Mon Sep 17 00:00:00 2001
From: "Roger A. Light" <roger@atchoo.org>
Date: Fri, 8 Jan 2021 17:06:30 +0000
Subject: [PATCH] `install` Makefile target should depend on `all`, not
 `mosquitto`

This ensures that man pages are always built, even if a user runs `make
install` without building first.

Closes #1989. Thanks to woodz-.
---
 ChangeLog.txt | 4 ++++
 Makefile      | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/ChangeLog.txt b/ChangeLog.txt
index 571c6edfe5..4c0376db07 100644
--- a/ChangeLog.txt
+++ b/ChangeLog.txt
@@ -13,6 +13,10 @@ Broker:
   before a role that was attached to the group or client is deleted.
   Closes #1998.
 
+Build:
+- `install` Makefile target should depend on `all`, not `mosquitto`, to ensure
+  that man pages are always built. Closes #1989.
+
 Apps:
 - Disallow control characters in mosquitto_passwd usernames.
 - Fix incorrect description in mosquitto_ctrl man page. Closes #1995.
diff --git a/Makefile b/Makefile
index 17c76daeb1..ebc2ee0ea2 100644
--- a/Makefile
+++ b/Makefile
@@ -87,7 +87,7 @@ ptest : mosquitto
 utest : mosquitto
 	$(MAKE) -C test utest
 
-install : mosquitto
+install : all
 	set -e; for d in ${DIRS}; do $(MAKE) -C $${d} install; done
 ifeq ($(WITH_DOCS),yes)
 	set -e; for d in ${DOCDIRS}; do $(MAKE) -C $${d} install; done