Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable UserResource in airlines app #510

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

Azquelt
Copy link
Member

@Azquelt Azquelt commented Feb 22, 2022

Currently, the TCK verifies that the implementation creates paths and
operations for UserResource, even though it isn't configured as a rest
resource.

The spec doesn't demand that this should or shouldn't happen and it
makes sense for implementations to be allowed to check which resources
are actually included in the rest application and only generate schema
for those that are.

Fixes #498

Currently, the TCK verifies that the implementation creates paths and
operations for UserResource, even though it isn't configured as a rest
resource.

The spec doesn't demand that this should or shouldn't happen and it
makes sense for implementations to be allowed to check which resources
are actually included in the rest application and only generate schema
for those that are.
Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikeEdgar MikeEdgar added this to the MP OpenAPI 3.1 milestone Feb 23, 2022
@Azquelt Azquelt merged commit 3b93e7a into eclipse:master Feb 23, 2022
@Azquelt Azquelt deleted the add-user-resource branch February 23, 2022 14:00
@Azquelt Azquelt removed this from the MP OpenAPI 3.1 milestone Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TCK error - OASConfigExcludeClassesTest$testExcludedClasses requires incorrect OpenAPI document to pass
2 participants