Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add general Number comparison Matcher, update pet store assertions #418

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Add general Number comparison Matcher, update pet store assertions #418

merged 1 commit into from
Apr 14, 2020

Conversation

MikeEdgar
Copy link
Member

Fixes #412

@MikeEdgar
Copy link
Member Author

@tjquinno, FYI

EricWittmann
EricWittmann approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@EricWittmann EricWittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

arthurdm
arthurdm approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@arthurdm arthurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arthurdm arthurdm merged commit 52ac121 into eclipse:master Apr 14, 2020
@MikeEdgar MikeEdgar deleted the 412_number_comparison_matcher branch April 14, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricWittmann EricWittmann EricWittmann approved these changes

@arthurdm arthurdm arthurdm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TCK bug? Use of equalTo PetStoreAppTest#testSchema rejects 10.0 for schema.multipleOf
3 participants
@MikeEdgar @EricWittmann @arthurdm