Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EaseMesh to 2.0 #696

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Upgrade EaseMesh to 2.0 #696

merged 2 commits into from
Jul 21, 2022

Conversation

xxx7xxxx
Copy link
Contributor

@xxx7xxxx xxx7xxxx commented Jul 9, 2022

Since unit tests have already worked well, I Will do the integration test soon.

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2022

Codecov Report

Merging #696 (27b1692) into main (84fba19) will decrease coverage by 0.01%.
The diff coverage is 72.91%.

@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
- Coverage   80.04%   80.03%   -0.02%     
==========================================
  Files          93       95       +2     
  Lines       10100    10618     +518     
==========================================
+ Hits         8085     8498     +413     
- Misses       1540     1626      +86     
- Partials      475      494      +19     
Impacted Files Coverage Δ
pkg/object/meshcontroller/spec/spec.go 79.28% <71.94%> (ø)
pkg/filters/proxy/loadbalance.go 98.86% <100.00%> (ø)
pkg/object/meshcontroller/spec/selector.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84fba19...27b1692. Read the comment docs.

backendName := "backend"

func (b *pipelineSpecBuilder) appendProxy(mainServers []*proxy.Server,
lb *proxy.LoadBalanceSpec, timeout string,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timeout is not used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, updated

@xxx7xxxx xxx7xxxx merged commit d9ad9d6 into easegress-io:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants