From 5f34fa670fa43f6028bab2a227d78811da560c78 Mon Sep 17 00:00:00 2001 From: guoguangwu Date: Sat, 8 Jul 2023 17:01:25 +0800 Subject: [PATCH] chore: slice replace loop --- pkg/object/consulserviceregistry/client.go | 4 +--- pkg/object/serviceregistry/service.go | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/pkg/object/consulserviceregistry/client.go b/pkg/object/consulserviceregistry/client.go index 2eefd33624..38228d379a 100644 --- a/pkg/object/consulserviceregistry/client.go +++ b/pkg/object/consulserviceregistry/client.go @@ -72,9 +72,7 @@ func (c *consulAPIClient) ListAllServiceInstances() ([]*api.CatalogService, erro return nil, fmt.Errorf("pull catalog service %s failed: %v", serviceName, err) } - for _, service := range services { - catalogServices = append(catalogServices, service) - } + catalogServices = append(catalogServices, services...) } return catalogServices, nil diff --git a/pkg/object/serviceregistry/service.go b/pkg/object/serviceregistry/service.go index ceda490c68..63023e52f8 100644 --- a/pkg/object/serviceregistry/service.go +++ b/pkg/object/serviceregistry/service.go @@ -51,9 +51,7 @@ func (s *ServiceInstanceSpec) DeepCopy() *ServiceInstanceSpec { copy := *s if s.Tags != nil { - for _, tag := range s.Tags { - copy.Tags = append(copy.Tags, tag) - } + copy.Tags = append(copy.Tags, s.Tags...) } return ©