Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachment sync not working on Deno runtime #297

Closed
sgwilym opened this issue Jan 10, 2023 · 1 comment · Fixed by #306
Closed

Attachment sync not working on Deno runtime #297

sgwilym opened this issue Jan 10, 2023 · 1 comment · Fixed by #306

Comments

@sgwilym
Copy link
Contributor

sgwilym commented Jan 10, 2023

What's the problem you want solved?

Syncing attachments larger than 256kb breaks with peers syncing with PartnerWebServer / PartnerWebClient running on the Deno runtime. This is being caused by Deno not sending all messages.

Is there a solution you'd like to recommend?

For the time being users should stick to Deno 1.26.2, which does not drop WebSocket messages.

Deno need to fix their WebSocket implementation. I have created a issue for these unsent message: denoland/deno#17332

Reproduction case: https://github.com/sgwilym/deno-ws-bug-repro

@sgwilym
Copy link
Contributor Author

sgwilym commented Jan 21, 2023

Seems like this will be fixed in Deno 1.30 thanks to this: denoland/deno#17480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant