Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review sits_patterns #98

Closed
pedro-andrade-inpe opened this issue Oct 17, 2018 · 1 comment
Closed

Review sits_patterns #98

pedro-andrade-inpe opened this issue Oct 17, 2018 · 1 comment

Comments

@pedro-andrade-inpe
Copy link
Contributor

Review sits_patterns:

  1. Argument timeline is useless
  2. Arguments start_date and end_date are not month-day. They should be a Date, or a string that could be converted to a Date. The code below does not work:
data(cerrado_2classes)
patterns.tb <- sits_patterns(cerrado_2classes, start_date ="09-13", end_date = "08-29")
  1. If start_date is set as argument but not end_date, start_date will be overwritten, and vice-versa.
        if (purrr::is_null(start_date) || purrr::is_null(end_date)) {
            start_date <- lubridate::as_date(utils::head(sample_dates, n = 1))
            end_date   <- lubridate::as_date(utils::tail(sample_dates, n = 1))
        }
@gilbertocamara
Copy link
Contributor

Solved in version 0.08.06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants