Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to the core module #15

Open
ghacupha opened this issue Aug 14, 2018 · 0 comments
Open

Add tests to the core module #15

ghacupha opened this issue Aug 14, 2018 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ghacupha
Copy link
Member

ghacupha commented Aug 14, 2018

Expected Behavior

We need to increase test coverage in the core module, on which all other modules depend

Current Behavior

The current coverage for the core module is at 76%. Room for improvement.

Possible Solution

-Stick to Junit as amuch as possible. Mockito may not be necessary. We can generate class and XSDs to do round-trip tests where we are using JAXB api.
-The code has a lot of static methods, supposed to make use of the api easier. This consists the bulk of useful untested code. We could instead initiate such classes using double-check locking singletons, turn the static methods to instance methods.

  • Use dependency injection pattern instead of configuring dependencies inside the classes. This would make the code more testable and maintainable.
  • As much as possible reduce side effects
@ghacupha ghacupha added the enhancement New feature or request label Aug 14, 2018
@ghacupha ghacupha added this to To do in Test Project via automation Aug 14, 2018
@ghacupha ghacupha added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Test Project
  
To do
Development

No branches or pull requests

1 participant