Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for className when icon has background #48

Open
brugaspar opened this issue Apr 5, 2024 · 0 comments
Open

Add support for className when icon has background #48

brugaspar opened this issue Apr 5, 2024 · 0 comments

Comments

@brugaspar
Copy link

brugaspar commented Apr 5, 2024

Add support for className when icon has weight "fill" or "duotone". When you set weight to thin, light, regular or bold, the className works fine, because the "fill" prop in SVG is currentColor, but when the weight is fill or duotone, the "fill" prop in SVG is set to props.color, losing the color passed through className.

I'm using Nativewind, so when I use something like "text-zinc-800", it only works with weights that don't have background, e.g. regular.

coldcode

I did some tests and I think this could be removed, since "currentColor" works for both "fill" and "duotone" as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant