-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding plot_kernel() function to utils #13
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
- Coverage 97.03% 96.81% -0.22%
==========================================
Files 7 7
Lines 438 440 +2
==========================================
+ Hits 425 426 +1
- Misses 13 14 +1
Continue to review full report at Codecov.
|
Nice, thanks! I recently factored the kernel creation in to a separate function ( I'm a little uncomfortable with the lack of test coverage in utils.py too. Testing plots is a pain but maybe we should split the plotting routines in to a separate file? |
Nice idea! I'll look into that now In terms of tests I was thinking primarily of checking that the assertions fail correctly (if the user gives an incorrect kernel name) and maybe also checking that the |
@duncanwp I've made a small change to |
I like the idea but I'm not a big fan of optionally returning a different number of arguments, it can make code a bit hard to visually debug. Looking at it again maybe |
Example usage below. Hoping this will make exploring different kernels a bit easier for users.
To-do: