perf: optimize Buffer.from("base64") for forgiving-base64 conforming …

…input (denoland#24346)
dsherret · Jun 26, 2024 · 2549e51 · 2549e51
1 parent 6da8745
commit 2549e51
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/ext/node/polyfills/internal_binding/_utils.ts b/ext/node/polyfills/internal_binding/_utils.ts
@@ -18,9 +18,13 @@ export function asciiToBytes(str: string) {
 }
 
 export function base64ToBytes(str: string) {
- str = base64clean(str);
- str = str.replaceAll("-", "+").replaceAll("_", "/");
- return forgivingBase64Decode(str);
+ try {
+ return forgivingBase64Decode(str);
+ } catch {
+ str = base64clean(str);
+ str = str.replaceAll("-", "+").replaceAll("_", "/");
+ return forgivingBase64Decode(str);
+ }
 }
 
 const INVALID_BASE64_RE = /[^+/0-9A-Za-z-_]/g;