-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Illegal folder names in modstore stops the launcher root directory from being deleted. #338
Comments
Doesnt this sound like a defect with the mod, and not the launcher? |
I don't think the mods creators intended the mods files to be stored outside the JAR file by a user, none the less I did make a issue for the mod too. But this issue is exclusive to helious because it doesn't store mods in JAR files like other launchers. |
The launcher does not extract any files from mod jars? |
@Tjmaxmillion can I take a look at your distribution file? |
The mod Create: Interactive has a folder called
aux
located at "org\valkyrienskies\create_interactive\aux" in the JAR.When this mod is moved to the modstore the
aux
folder ends up there meaning the root directory of the launcher can't be deleted until theaux
folder is deleted with the command line.For a normal user it's unlikely for them to find the aux folder and know this is what is preventing them from deleting the root directory of the launcher.
Further I doubt a normal user would know how to use the command line to delete this folder.
Implement something to help with edge cases where Illegal folder/files names are used in jar files?
Image Source
![image](https://private-user-images.githubusercontent.com/76654305/308745610-92817115-f922-40e0-a59a-fc92926f46e1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI3OTU5OTgsIm5iZiI6MTcyMjc5NTY5OCwicGF0aCI6Ii83NjY1NDMwNS8zMDg3NDU2MTAtOTI4MTcxMTUtZjkyMi00MGUwLWE1OWEtZmM5MjkyNmY0NmUxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MDQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODA0VDE4MjEzOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBkYzU2OTZiMmQ0YmZmYjFlYmU0OTFhMDU3NTIzZTc1NmYzYjQxY2I0Mjg3ZTEyYWU3ZTE1YmYyZGQxYTcwMDkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.-3rcIYfR5r2bkH5qvxWCL5KO3KmmUJ0t5KNORJ1NjtQ)
The text was updated successfully, but these errors were encountered: