From 7357007a6325373f4df3d8fc5d9f008a6ec97862 Mon Sep 17 00:00:00 2001 From: Hugo Giraudel Date: Thu, 18 Feb 2016 13:10:09 +0100 Subject: [PATCH] Prevented an extra loop when jQuery is present --- modal.js | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/modal.js b/modal.js index 563c469..3fb7674 100644 --- a/modal.js +++ b/modal.js @@ -49,18 +49,15 @@ if (!elements.length) { elements = [elements]; } - - for (; i < elements.length; i++) { - - // If jQuery is supported - if ($) { - $(elements[i]).on(event, callback); - - // Default way to support events - } else if ('addEventListener' in elements[i]) { - elements[i].addEventListener(event, callback, false); + + // If jQuery is supported + if ($) { + $(elements).on(event, callback); + // Default way to support events + } else { + for (; i < elements.length; i++) { + elements[i].addEventListener && elements[i].addEventListener(event, callback, false); } - } },